Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mks custom pins and clean up TINYBEE pins #24186

Merged
merged 5 commits into from
May 24, 2022

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented May 16, 2022

Description

MKS implementation of u8g_esp32_spi.cpp uses custom mks pins, not pins defined in the motherboards pin.h file.
Removed these custom pins
Cleaned up pins_MKS_TINYBEE.h
Addressed MKS12864 pin issue 24184

Requirements

A MKS TINYBEE
With a supported LCD

Benefits

Cleaner code
works on MKS12864 displays.

Related Issues

Issue #24184

@ellensp ellensp added Needs: Testing Testing is needed for this change C: Boards/Pins PR: Bug Fix and removed Needs: Testing Testing is needed for this change labels May 16, 2022
@ellensp
Copy link
Contributor Author

ellensp commented May 17, 2022

User has confirm this works

@ellensp
Copy link
Contributor Author

ellensp commented May 17, 2022

I've also tested on MKS_TINYBEE with FYSETC_MINI_12864_2_1

@ellensp ellensp added the S: Don't Merge Work in progress or under discussion. label May 19, 2022
@ellensp
Copy link
Contributor Author

ellensp commented May 19, 2022

Don't merge yet, Documentation says is also supports LCD2004, 12864 screens, though code doesn't enable spi for the latter...
want to look into both of these.

@ellensp ellensp marked this pull request as draft May 19, 2022 16:07
@ellensp
Copy link
Contributor Author

ellensp commented May 23, 2022

Confirmed works on REPRAP_DISCOUNT_SMART_CONTROLLER and REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER but like all mks products exp1 and exp2 are rotated 180 degrees, so cables need to be rotated to work.

@ellensp ellensp removed the S: Don't Merge Work in progress or under discussion. label May 23, 2022
@ellensp ellensp marked this pull request as ready for review May 23, 2022 03:19
@thinkyhead
Copy link
Member

…like all mks products exp1 and exp2 are rotated 180 degrees…

So if I wanted to connect, say, the MKS_TS35_V2_0 to a BTT board, the cables would need to be rotated 180°? Or is that display's pins in the correct orientation? Also, I see this MKS display requires 3.3V on EXP2-01 which MKS boards provide, but other boards might not. With 3.3V on that pin, it should be adaptable to any board.

Yeah, I've got LCD unification on my mind lately. I might take a stab at making a RRDFGSC.h file that can be included by pins.h and see what ends up being required to make it doable.

@thinkyhead thinkyhead merged commit e197695 into MarlinFirmware:bugfix-2.0.x May 24, 2022
@thisiskeithb
Copy link
Member

So if I wanted to connect, say, the MKS_TS35_V2_0 to a BTT board, the cables would need to be rotated 180°?

Correct. All of MKS' EXP pins are 180 out compared to other boards/brands. MKS even made two videos about it here and here.

@ellensp ellensp deleted the tinybee-cleanup branch May 24, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants