-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove mks custom pins and clean up TINYBEE pins #24186
remove mks custom pins and clean up TINYBEE pins #24186
Conversation
User has confirm this works |
I've also tested on MKS_TINYBEE with FYSETC_MINI_12864_2_1 |
Don't merge yet, Documentation says is also supports LCD2004, 12864 screens, though code doesn't enable spi for the latter... |
Confirmed works on REPRAP_DISCOUNT_SMART_CONTROLLER and REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER but like all mks products exp1 and exp2 are rotated 180 degrees, so cables need to be rotated to work. |
So if I wanted to connect, say, the Yeah, I've got LCD unification on my mind lately. I might take a stab at making a |
Description
MKS implementation of u8g_esp32_spi.cpp uses custom mks pins, not pins defined in the motherboards pin.h file.
Removed these custom pins
Cleaned up pins_MKS_TINYBEE.h
Addressed MKS12864 pin issue 24184
Requirements
A MKS TINYBEE
With a supported LCD
Benefits
Cleaner code
works on MKS12864 displays.
Related Issues
Issue #24184